Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fixed manager_webhook_patch not uncommented #3427

Merged
merged 1 commit into from
May 23, 2023

Conversation

lauchokyip
Copy link
Contributor

Fixes #3426

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @lauchokyip. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2023
@@ -36,7 +36,7 @@ patchesStrategicMerge:

# [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix including the one in
# crd/kustomization.yaml
#- manager_webhook_patch.yaml
- manager_webhook_patch.yaml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you've already made the changes in the file hack/docs/internal/cronjob-tutorial/generate_cronjob.go, do we really need the change here in this file? Asking because this will by overwritten by make generate (and hence make generate-docs) as mentioned by @camilamacedo86 .

Copy link
Contributor Author

@lauchokyip lauchokyip May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI will run make generate that's why this file is included as part of the changes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand, make generate will overwrite the file docs/book/src/cronjob-tutorial/testdata/project/config/default/kustomization.yaml, right?

If so, then do we explicitly need to make this change here? Else, this can be skipped. Thanks!

Copy link
Contributor Author

@lauchokyip lauchokyip May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make generate will generate the file, that's why changes need to be done in hack/docs/internal/cronjob-tutorial/generate_cronjob.go.

Once changes are made over there, I just run make generate and docs/book/src/cronjob-tutorial/testdata/project/config/default/kustomization.yaml was automatically been changed.

The CI will run make generate and compare with the PR, and therefore it will fail if I didn't run make generate before submitting the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, lauchokyip, manavrajvanshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit db9def4 into kubernetes-sigs:master May 23, 2023
@manavrajvanshi
Copy link

@camilamacedo86 , I see the issue I reported has been closed since this PR has been merged. Just curious to know how long does it take for the changes to reflect on the Kubebuilder book?
Asking because I still see the comment #- manager_webhook_patch.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs/book] running webhook (config/default/kustomization.yaml) not working
4 participants